Support placement_group=None in PlacementGroupSchedulingStrategy #27370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
jjyao
requested review from
maxpumperla,
pcmoritz,
richardliaw,
edoakes,
simon-mo and
ericl
as code owners
jjyao
commented
Aug 2, 2022
| because the resource request {'CPU': 10} cannot fit into any bundles for the placement group, [{'CPU': 1.0}]. | ||
|
|
||
| **Expected behavior**: The above executes. | ||
|
|
||
| **Fix**: In the ``@ray.remote`` declaration of tasks | ||
| called by ``create_task_that_uses_resources()`` , include a | ||
| ``placement_group=None``. | ||
| ``scheduling_strategy=PlacementGroupSchedulingStrategy(placement_group=None)``. |
There was a problem hiding this comment.
Still feel a bit weird that we specify a strategy just to not use that strategy.
There was a problem hiding this comment.
We allow both right? Because in Datasets, we override using DEFAULT.
There was a problem hiding this comment.
Yes, currently we allow both.
ericl
approved these changes
Aug 2, 2022
ericl
pushed a commit
that referenced
this pull request
Aug 3, 2022
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…-project#27370) We decided to allow escaping the parent pg via `PlacementGroupSchedulingStrategy(placement_group=None)` instead of using "DEFAULT". Our doc is updated with that but in the code it's still not allowed. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We decided to allow escaping the parent pg via
PlacementGroupSchedulingStrategy(placement_group=None)instead of using "DEFAULT". Our doc is updated with that but in the code it's still not allowed.Related issue number
Closes #27328
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.